[Intel-gfx] [PATCH 2/4] drm/i915: Introduce a vfunc for platform-specfic MMIO flip code

[Ander Conselvan de Oliveira]

On 10/27/2014 04:25 PM, Daniel Vetter wrote:
> On Mon, Oct 27, 2014 at 11:08:20AM +0000, Damien Lespiau wrote:
>> On Mon, Oct 27, 2014 at 10:16:06AM +0100, Daniel Vetter wrote:
>>> On Sat, Oct 25, 2014 at 12:11:12AM +0100, Damien Lespiau wrote:
>>>> SKL will specialize it.
>>>>
>>>> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
>>>
>>> So with atomic I'd expect that we'd have one giant mmio_flip driver
>>> function and that just calls into the relevant platform/plane update
>>> hooks. Gustavo&Ville are working on that monster.
>>>
>>> Now this here seems to add another incarnation. Can't I have just one
>>> please?
>>
>> I'd be happy to have that, but are we talking before 3.19? SKL doesn't
>> flip at all without MMIO flips, so we'll need to have of of those by
>> 3.19.
>
> It shouldn't be a lot of fuzz really since it will more or less amount to
> calling the same low-level plane update functions for all of them. Or I'm
> confused about all this. Also I think Ander is starting to rework
> mmio_flip this week.

I did send a patch [1] related to mmio flip last week, but I wasn't 
aware of the grand plan for that "giant mmio_flip driver function". I'm 
learning the details as I go, so I should probably look into that, but 
at least for now I wasn't planning to much more than that patch.

Paulo gave me some comments (off-list, due to the mailman issues) that I 
plan to fix and then send a v2.

  [1] 
http://lists.freedesktop.org/archives/intel-gfx/2014-October/053792.html

Cheers,
Ander