[Intel-gfx] [PATCH] drm/i915: Redefine WARN_ON to include the condition
Mika Kuoppala
miku at iki.fi
Tue Oct 28 16:32:30 CET 2014
When looking at the bug report logs with triggered
WARN_ON, the person doing bug triaging will have to
find exact kernel source and match file/line.
Attach the condition that triggered the WARN_ON
to kernel log. In most cases the context is self
evident and this way we can save developer time.
The drawback is ~16kbytes bigger i915.ko
Signed-off-by: Mika Kuoppala <miku at iki.fi>
---
drivers/gpu/drm/i915/i915_drv.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 6a73803..b6fb30f 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -57,6 +57,9 @@
#define DRIVER_DESC "Intel Graphics"
#define DRIVER_DATE "20141024"
+#undef WARN_ON
+#define WARN_ON(x) WARN(x, "WARN_ON(" #x ")")
+
enum pipe {
INVALID_PIPE = -1,
PIPE_A = 0,
--
1.9.1
More information about the Intel-gfx
mailing list