[Intel-gfx] [PATCH 02/14] drm/i915: Use DPINVGTT_STATUS_MASK

[Paulo Zanoni]

2014-10-30 15:42 GMT-02:00  <ville.syrjala at linux.intel.com>:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Some has given a name for the DPINVGTT status bitmask, so let's use it
> instead of the magic number. Looks more like the chv code now.

Notice that valleyview_irq_postinstall() contains a write using the
correct name, but it's under an "#if 0" with a FIXME comment. You
might want to audit that.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 98a8d65..e41272d 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3122,7 +3122,7 @@ static void valleyview_irq_preinstall(struct drm_device *dev)
>
>         gen5_gt_irq_reset(dev);
>
> -       I915_WRITE(DPINVGTT, 0xff);
> +       I915_WRITE(DPINVGTT, DPINVGTT_STATUS_MASK);
>
>         I915_WRITE(PORT_HOTPLUG_EN, 0);
>         I915_WRITE(PORT_HOTPLUG_STAT, I915_READ(PORT_HOTPLUG_STAT));
> --
> 2.0.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni