[Intel-gfx] [PATCH 07/14] drm/i915: Call gen5_gt_irq_reset() from valleyview_irq_uninstall()

[Paulo Zanoni]

2014-10-30 15:42 GMT-02:00  <ville.syrjala at linux.intel.com>:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Looks like we forgot to call gen5_gt_irq_reset() for vlv in the
> uninstall phase. Do so.

I also see that valleyview_irq_preinstall() contains 2 writes to GTIIR
just before calling gen5_gt_irq_reset(), which should already clear
GTIIR, and at the right order. On a quick look, none of your later
patches seem to do that, so you could write patch 15/14 for that...

Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index c106bba..67c046b 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3588,6 +3588,8 @@ static void valleyview_irq_uninstall(struct drm_device *dev)
>
>         I915_WRITE(VLV_MASTER_IER, 0);
>
> +       gen5_gt_irq_reset(dev);
> +
>         for_each_pipe(dev_priv, pipe)
>                 I915_WRITE(PIPESTAT(pipe), 0xffff);
>
> --
> 2.0.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni