[Intel-gfx] [PATCH 1/2] drm/i915/dp: Cache EDID for a detection cycle

Chris Wilson chris at chris-wilson.co.uk
Mon Sep 1 14:24:39 CEST 2014


On Mon, Sep 01, 2014 at 03:05:26PM +0300, Ville Syrjälä wrote:
> On Tue, Aug 12, 2014 at 09:36:03AM +0100, Chris Wilson wrote:
> > As we may query the edid multiple times following a detect, record the
> > EDID found during output discovery and reuse it. This is a separate
> > issue from caching the output EDID across detection cycles.
> 
> My only real concern here is what happens when someone forces the
> connector to connected. Given you only populate detect_edid in
> ->detect() we wouldn't be able to get the modes from the EDID in
> that case.
> 
> I guess one solution would be to implement the ->force() hook and
> attempt the edid read there. Looking at the code we should always do
> a ->detect() or ->force() before ->get_modes().

That should fix our audio detection in those cases as well. Sounds good.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list