[Intel-gfx] [PATCH 0/4] Rework workaround init fn for BDW and CHV

Arun Siluvery arun.siluvery at linux.intel.com
Mon Sep 1 15:28:49 CEST 2014


The patches that initialize workarounds for BDW and CHV using LRIs
are already merged in the tree but I received few more comments
from Chris and Damien.

I have reworked these patches as per their comments; it fixes
some issues and the code now looks clean. we can easily add
more workarounds with minimal changes.

I have tried to split BDW and CHV changes as separate patches but
it was getting ugly hence combined them also since it is a fixup
patch it should be ok.

In the previous implementation we were emitting each LRI individually
so the total number was not clear during init so a temporary array
was used to save w/a data (this is exported to debugfs) but if not
initialized we could potentially overrun array and also the condition
was not correct.
In this rework, w/a are organized as an array so we know the exact
count from the beginning and temporary array is no longer required.

The corresponding i-g-t is gem_workarounds.c and it is also updated.

Arun Siluvery (2):
  drm/i915: Rework workaround init functions for BDW and CHV
  drm/i915: Rework workaround data exporting to debugfs

Damien Lespiau (2):
  drm/i915: Rename intel_wa_registers with a i915_ prefix
  drm/i915: Don't restrict i915_wa_registers to BDW

 drivers/gpu/drm/i915/i915_debugfs.c     |  42 ++++++---
 drivers/gpu/drm/i915/i915_drv.h         |  14 ---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 162 ++++++++++++++------------------
 drivers/gpu/drm/i915/intel_ringbuffer.h |   8 ++
 4 files changed, 107 insertions(+), 119 deletions(-)

-- 
2.0.4




More information about the Intel-gfx mailing list