[Intel-gfx] [PATCH] drm/i915: Don't spam dmesg with rps messages on vlv/chv

[Jani Nikula]

On Tue, 02 Sep 2014, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> If the GPU frequency isn't going to change don't spam dmesg with
> debug messages about it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Oh yes please!

Reviewed-by: Jani Nikula <jani.nikula at intel.com>


> ---
>  drivers/gpu/drm/i915/intel_pm.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 78e39f8..9bc44f0 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3488,17 +3488,18 @@ void valleyview_set_rps(struct drm_device *dev, u8 val)
>  	WARN_ON(val > dev_priv->rps.max_freq_softlimit);
>  	WARN_ON(val < dev_priv->rps.min_freq_softlimit);
>  
> -	DRM_DEBUG_DRIVER("GPU freq request from %d MHz (%u) to %d MHz (%u)\n",
> -			 vlv_gpu_freq(dev_priv, dev_priv->rps.cur_freq),
> -			 dev_priv->rps.cur_freq,
> -			 vlv_gpu_freq(dev_priv, val), val);
> -
>  	if (WARN_ONCE(IS_CHERRYVIEW(dev) && (val & 1),
>  		      "Odd GPU freq value\n"))
>  		val &= ~1;
>  
> -	if (val != dev_priv->rps.cur_freq)
> +	if (val != dev_priv->rps.cur_freq) {
> +		DRM_DEBUG_DRIVER("GPU freq request from %d MHz (%u) to %d MHz (%u)\n",
> +				 vlv_gpu_freq(dev_priv, dev_priv->rps.cur_freq),
> +				 dev_priv->rps.cur_freq,
> +				 vlv_gpu_freq(dev_priv, val), val);
> +
>  		vlv_punit_write(dev_priv, PUNIT_REG_GPU_FREQ_REQ, val);
> +	}
>  
>  	I915_WRITE(GEN6_PMINTRMSK, gen6_rps_pm_mask(dev_priv, val));
>  
> -- 
> 1.8.5.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center