[Intel-gfx] [PATCH 2/2] intel/uxa: add MST support.

Chris Wilson chris at chris-wilson.co.uk
Wed Sep 3 09:28:12 CEST 2014


On Wed, Sep 03, 2014 at 10:43:21AM +1000, Dave Airlie wrote:
> @@ -808,6 +815,11 @@ intel_output_attach_edid(xf86OutputPtr output)
>  	xf86MonPtr mon = NULL;
>  	int i;
>  
> +	if (!koutput) {
> +		xf86OutputSetEDID(output, mon);
> +		return;
> +	}
> +
>  	/* look for an EDID property */
>  	for (i = 0; i < koutput->count_props; i++) {
>  		drmModePropertyPtr props;
> @@ -897,6 +909,9 @@ intel_output_get_modes(xf86OutputPtr output)
>  
>  	intel_output_attach_edid(output);
>  
> +	if (!koutput)
> +		return Modes;
> +
>  	/* modes should already be available */
>  	for (i = 0; i < koutput->count_modes; i++) {
>  		DisplayModePtr Mode;

You don't hook into intel_output_detect() and report disconnected? Oh,
the code will already fail at drmModeGetConector().

So given that the output is disconnected, these two should never be
called?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list