[Intel-gfx] [PATCH 1/2] drm/i915: clear up wedged transitions

Daniel Vetter daniel.vetter at ffwll.ch
Thu Sep 4 08:03:26 CEST 2014


On Wed, Sep 3, 2014 at 10:26 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
>> @@ -1385,7 +1372,7 @@ out:
>>               /* If this -EIO is due to a gpu hang, give the reset code a
>>                * chance to clean up the mess. Otherwise return the proper
>>                * SIGBUS. */
>> -             if (!atomic_read(&dev_priv->gpu_error.wedged))
>> +             if (i915_terminally_wedged(&dev_priv->gpu_error))
>>                       return VM_FAULT_SIGBUS;
>
> (i915_gem_fault())
>
> This if() is backwards.

It should keep the logic mostly unchanged. But I guess returning
SIGBUS if the gpu died for real isn't too friendly?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list