[Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

[Rodrigo Vivi]

Here goes results on BDW  with pure today's nightly (with idle_frame=1)

# First run

IGT-Version: 1.7-gd4b43f0 (x86_64) (Linux: 3.17.0-rc2+ x86_64)
Subtest primary_page_flip: SUCCESS
Subtest primary_mmap_gtt: SUCCESS
Test assertion failure function test_crc, file kms_psr_sink_crc.c:307:
Failed assertion: strcmp(ref_crc, CRC_GREEN) != 0
Subtest primary_mmap_gtt_waiting: FAIL
Subtest primary_mmap_cpu: SUCCESS
Subtest primary_blt: SUCCESS
Subtest primary_render: SUCCESS
Subtest sprite_mmap_gtt: SUCCESS
Waiting 10s...
Subtest sprite_mmap_gtt_waiting: SUCCESS
Subtest sprite_mmap_cpu: SUCCESS
Subtest sprite_blt: SUCCESS
Subtest sprite_render: SUCCESS
Subtest sprite_plane_move: SUCCESS
Subtest sprite_plane_onoff: SUCCESS
Subtest cursor_mmap_gtt: SUCCESS
Waiting 10s...
Subtest cursor_mmap_gtt_waiting: SUCCESS
Subtest cursor_mmap_cpu: SUCCESS
Subtest cursor_blt: SUCCESS
Subtest cursor_render: SUCCESS
Subtest cursor_plane_move: SUCCESS
Subtest cursor_plane_onoff: SUCCESS

#second run:

IGT-Version: 1.7-gd4b43f0 (x86_64) (Linux: 3.17.0-rc2+ x86_64)
Subtest primary_page_flip: SUCCESS
Subtest primary_mmap_gtt: SUCCESS
Waiting 10s...
Subtest primary_mmap_gtt_waiting: SUCCESS
Subtest primary_mmap_cpu: SUCCESS
Subtest primary_blt: SUCCESS
Subtest primary_render: SUCCESS
Subtest sprite_mmap_gtt: SUCCESS
Waiting 10s...
Subtest sprite_mmap_gtt_waiting: SUCCESS
Subtest sprite_mmap_cpu: SUCCESS
Subtest sprite_blt: SUCCESS
Test assertion failure function test_crc, file kms_psr_sink_crc.c:307:
Failed assertion: strcmp(ref_crc, CRC_GREEN) != 0
Subtest sprite_render: FAIL
Subtest sprite_plane_move: SUCCESS
Subtest sprite_plane_onoff: SUCCESS
Subtest cursor_mmap_gtt: SUCCESS
Waiting 10s...
Subtest cursor_mmap_gtt_waiting: SUCCESS
Subtest cursor_mmap_cpu: SUCCESS
Subtest cursor_blt: SUCCESS
Subtest cursor_render: SUCCESS
Subtest cursor_plane_move: SUCCESS
Subtest cursor_plane_onoff: SUCCESS

random failures! but better than hsw at least.

However the hardcoded color is indeed a mistake... Green on this panel is
different from the green on the other panel.
But I'm also not sure about drawing the color with cairo... How can we be
sure what is there is what we want anyway.

So maybe it is better to fall back to old scheme where we just check if
changed when we want it changes... without checking for colors.
What do you think?

Thanks,
Rodrigo.



On Thu, Sep 4, 2014 at 1:20 PM, Daniel Vetter <daniel at ffwll.ch> wrote:

> On Thu, Sep 4, 2014 at 9:16 PM, Rodrigo Vivi <rodrigo.vivi at gmail.com>
> wrote:
> >> Hm, I don't see a pattern at all. And that sprites seem to work best
> >> also looks funky. Are the results stable when you randomize them
> >> (piglit can do that for you)? Can you add a residency checks in the
> >> testcase (i.e. before the update and after the update) so that we know
> >> it's really psr and not something else funny going on? I assume this
> >> is on bdw, any difference in results on bdw?
> >
> > Yes, this is really strange. I couldn't find a pattern at all as well.
> > Do you have any example of piglit helping randomization?
> >
> > The bad things with residency check is that vlv/chv doesn't have
> performance
> > counters.
> > So this test would just work on hsw/bdw/
> >
> > I did this work on a HSW. Test on BDW is one of tests I should do next
> here.
>
> There's no shuffling in piglit unfortunately. But piglit is good for
> comparing results, so I wonder whether they are stable or change. And
> hsw is even more suprising since sprite tests pass more often in your
> example, but sprite also has now hw invalidate on hsw. Confusing.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
>



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20140904/deaf909b/attachment.html>