[Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

Imre Deak imre.deak at intel.com
Thu Sep 11 13:59:35 CEST 2014


On Thu, 2014-09-11 at 08:49 +0100, Chris Wilson wrote:
> On Wed, Sep 10, 2014 at 06:17:01PM +0300, Imre Deak wrote:
> > Since correctness wins over optimal code and since the optimization
> 
> Optimal code is also correct ;-) s/optimal/just plain broken/

Yes, bad wording. To clarify, since the optimization is now always off
anyway (and it's also broken), I would hope that we could remove it for
now and concentrate on fixing the existing s/r issues. Once we find that
things are stable enough we could add back this optimization.

--Imre

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20140911/6843ac0a/attachment.sig>


More information about the Intel-gfx mailing list