[Intel-gfx] [PATCH 2/2] drm/i915: Match GTT space sanity checker with implementation

[Chris Wilson]

On Thu, Sep 11, 2014 at 09:08:12AM +0100, Chris Wilson wrote:
> On Thu, Sep 11, 2014 at 10:02:27AM +0200, Daniel Vetter wrote:
> > On Wed, Sep 10, 2014 at 07:52:19PM +0100, Chris Wilson wrote:
> > > If we believe that the device can cross cache domains in its prefetcher
> > > (i.e. we allow neighbouring pages in different domains), we don't supply
> > > a color_adjust callback. Use the presence of this callback to better
> > > determine when we should be verifying that the GTT space we just
> > > used is valid.
> > > 
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > 
> > I guess this needs some serious beating on vlv/chv?
> 
> This shuts up the warning on byt+ by only running the checker when we
> actually insert guard pages. Whether or not we need to add guard pages
> on byt+ ppgtt is under scrutiny.

Actually it is a bit more than a warning. The sanity checker causes
execbuf to fail and the ddx to mark the kernel as broken and insane.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre