[Intel-gfx] [PATCH v3 1/4] drm/i915: Move the cursor_base setup to i{845, 9xx}_update_cursor()
Chris Wilson
chris at chris-wilson.co.uk
Sat Sep 13 18:15:35 CEST 2014
On Fri, Sep 12, 2014 at 08:53:32PM +0300, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> To make the code a bit more undestandable move the
> intel_crtc->cursor_base assignment into the low level update cursor
> routines. That's were we compare the current value with the new one
> so immediately seeing that it gets assigned only afterwards helps
> one to understand that it gets assigned only after the comparison.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
I'd been tempted to do this myself, but lacked justification.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx
mailing list