[Intel-gfx] [PATCH] drm/i915: Fix irq checks in ring->irq_get/put functions

Chris Wilson chris at chris-wilson.co.uk
Mon Sep 15 15:02:02 CEST 2014


On Mon, Sep 15, 2014 at 02:52:03PM +0200, Daniel Vetter wrote:
> Yet another place that wasn't properly transformed when implementing
> SOix. While at it convert the checks to WARN_ON on gen5+ (since we
> don't have UMS potentially doing stupid things on those platforms).
> And also add the corresponding checks to the put functions (again with
> a WARN_ON) for gen5+.
> 
> v2: Drop the WARNINGS in the irq_put functions (including the existing
> one for vebox), Chris convinced me that they're not that terribly
> useful.
> 
> v3: Don't forget about execlist code.
> 
> Cc: Imre Deak <imre.deak at intel.com>
> Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> Cc: "Volkin, Bradley D" <bradley.d.volkin at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

With the caveat that in my plan I am going to move the check into the
single caller of engine->irq_get(),

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list