[Intel-gfx] [PATCH] lib/core: Check for kernel error messages and FAIL if any are found

Chris Wilson chris at chris-wilson.co.uk
Wed Sep 17 18:01:11 CEST 2014


On Wed, Sep 17, 2014 at 05:54:52PM +0200, Daniel Vetter wrote:
> On Wed, Sep 17, 2014 at 12:34:46PM +0100, Chris Wilson wrote:
> > At the end of a subtest, check for any WARNs or ERRORs (or worse!)
> > emitted since the start of our test and FAIL the subtest if any are
> > found. This will prevent silent failures due to oops from going amiss or
> > being falsely reported as TIMEOUTs.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> We already have this in piglit, including filtering for non-i915 issues
> (which especially on s/r tests happen a lot). So this just duplicates
> that.

What piglit? I don't see QA reports involving pigligt and they seem to
mistake kernel OOPSes for benign TIMEOUTs quite frequently.
 
> Also imo it's nice to differentiate between test failures and dmesg noise
> in at least some tests, so clamping to fail isn't the righ thing to do I
> think.

Also where is my XFAIL? :)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list