[Intel-gfx] [PATCH] lib/core: Check for kernel error messages and FAIL if any are found

[Daniel, Thomas]

> -----Original Message-----
> From: daniel.vetter at ffwll.ch [mailto:daniel.vetter at ffwll.ch] On Behalf Of
> Daniel Vetter
> Sent: Wednesday, September 17, 2014 5:14 PM
> To: Chris Wilson; Daniel Vetter; intel-gfx; Daniel, Thomas
> Subject: Re: [Intel-gfx] [PATCH] lib/core: Check for kernel error messages
> and FAIL if any are found
> 
> On Wed, Sep 17, 2014 at 6:01 PM, Chris Wilson <chris at chris-wilson.co.uk>
> wrote:
> > On Wed, Sep 17, 2014 at 05:54:52PM +0200, Daniel Vetter wrote:
> >> On Wed, Sep 17, 2014 at 12:34:46PM +0100, Chris Wilson wrote:
> >> > At the end of a subtest, check for any WARNs or ERRORs (or worse!)
> >> > emitted since the start of our test and FAIL the subtest if any are
> >> > found. This will prevent silent failures due to oops from going
> >> > amiss or being falsely reported as TIMEOUTs.
> >> >
> >> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >>
> >> We already have this in piglit, including filtering for non-i915
> >> issues (which especially on s/r tests happen a lot). So this just
> >> duplicates that.
> >
> > What piglit? I don't see QA reports involving pigligt and they seem to
> > mistake kernel OOPSes for benign TIMEOUTs quite frequently.
> 
> Can you please reply with the relevant bugzillas? Since about 2 months QA is
> supposed to be using the piglit runner for their framework, so any difference
> in test results compared to what piglit would report is fail.
> 
> Note though that the piglit timeout support was busted by some refactoring
> from Dylan Baker, Thomas has patches to fix that again.
I haven't seen any patches for piglit...

Thomas.