[Intel-gfx] [RFC PATCH] drm/i915: add new intel audio file to group DP/HDMI audio

Daniel Vetter daniel at ffwll.ch
Thu Sep 18 15:38:51 CEST 2014


On Thu, Sep 18, 2014 at 3:37 PM, Jani Nikula <jani.nikula at intel.com> wrote:
> On Thu, 18 Sep 2014, Daniel Vetter <daniel at ffwll.ch> wrote:
>> lgtm, but I think to make code extraction into new files really worth
>> it this should be followed up with a small patch to add an overview
>> DOC section and kerneldoc for the non-static functions. Plus pulling
>> it all in at a neat place into our driver docs.
>
> Can do; the main point of the patch was to get feedback and decide
> whether to do some cleanups on the code within intel_display.c or to
> move it elsewhere first.

I'd move first, then clean up. Otherwise rebasing and polishing due to
review is super-painful.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list