[Intel-gfx] [PATCH 45/89] drm/i915/skl: Definition of SKL WM param structs for pipe/plane

[Damien Lespiau]

On Mon, Sep 22, 2014 at 05:06:11PM +0300, Ville Syrjälä wrote:
> > +struct skl_pipe_wm {
> > +	struct skl_wm_level wm[8];
> > +	struct skl_wm_level trans_wm;
> > +	uint32_t linetime;
> > +};
> > +
> >  struct intel_crtc {
> >  	struct drm_crtc base;
> >  	enum pipe pipe;
> > @@ -431,9 +437,11 @@ struct intel_crtc {
> >  	bool pch_fifo_underrun_disabled;
> >  
> >  	/* per-pipe watermark state */
> > -	struct {
> > +	union {
> 
> I almost gave my r-b, but then I noticed this. It's going to mess up my
> pending watermark series. I'm going to add tons of junk here, so union
> is not really acceptable for me. Needs some other solution.

Well, you could use an anonymous structure in that union? We could also
try to merge skl_pipe_wm and intel_pipe_wm at a later point? or just
leaving this a struct, wasting a tiny bit of memory be good enough for
now?

-- 
Damien