[Intel-gfx] [PATCH] drm/i915: Add RCS General Purpose Registers to parser whitelist

Daniel Vetter daniel at ffwll.ch
Tue Sep 23 10:38:49 CEST 2014


On Tue, Sep 23, 2014 at 12:41:50AM +0200, Michał Winiarski wrote:
> These registers are used as a temporary storage by MI_MATH command when
> performing ALU operations.
> 
> Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>

Needs to come with corresponding userspace using this. Also we need to rev
the cmd parser revision so that userspace can figure out whether a given
feature might work, see i915_cmd_parser_get_version.
-Daniel

> ---
>  drivers/gpu/drm/i915/i915_cmd_parser.c | 16 ++++++++++++++++
>  drivers/gpu/drm/i915/i915_reg.h        |  3 +++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915/i915_cmd_parser.c
> index 4c35e2a..9ad0e69 100644
> --- a/drivers/gpu/drm/i915/i915_cmd_parser.c
> +++ b/drivers/gpu/drm/i915/i915_cmd_parser.c
> @@ -414,6 +414,22 @@ static const u32 gen7_render_regs[] = {
>  	GEN7_3DPRIM_INSTANCE_COUNT,
>  	GEN7_3DPRIM_START_INSTANCE,
>  	GEN7_3DPRIM_BASE_VERTEX,
> +	REG64(CS_GPR(0)),
> +	REG64(CS_GPR(1)),
> +	REG64(CS_GPR(2)),
> +	REG64(CS_GPR(3)),
> +	REG64(CS_GPR(4)),
> +	REG64(CS_GPR(5)),
> +	REG64(CS_GPR(6)),
> +	REG64(CS_GPR(7)),
> +	REG64(CS_GPR(8)),
> +	REG64(CS_GPR(9)),
> +	REG64(CS_GPR(10)),
> +	REG64(CS_GPR(11)),
> +	REG64(CS_GPR(12)),
> +	REG64(CS_GPR(13)),
> +	REG64(CS_GPR(14)),
> +	REG64(CS_GPR(15)),
>  	REG64(GEN7_SO_NUM_PRIMS_WRITTEN(0)),
>  	REG64(GEN7_SO_NUM_PRIMS_WRITTEN(1)),
>  	REG64(GEN7_SO_NUM_PRIMS_WRITTEN(2)),
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index ad8179b..e5e7cca 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -461,6 +461,9 @@
>  
>  #define GEN7_SO_PRIM_STORAGE_NEEDED(n)  (0x5240 + (n) * 8)
>  
> +/* There are 16 64-bit RCS general purpose registers used by MI_MATH */
> +#define CS_GPR(n) (0x2600 + (n) * 8)
> +
>  #define GEN7_3DPRIM_END_OFFSET          0x2420
>  #define GEN7_3DPRIM_START_VERTEX        0x2430
>  #define GEN7_3DPRIM_VERTEX_COUNT        0x2434
> -- 
> 1.9.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list