[Intel-gfx] [PATCH 02/11] drm/i915: Clarify event_lock locking, irq&mixed context

Jike Song jike.song at intel.com
Mon Sep 29 08:20:27 CEST 2014


On 09/15/2014 08:55 PM, Daniel Vetter wrote:
> Now we tackle the functions also called from interrupt handlers.
>
> - intel_check_page_flip is exclusively called from irq handlers, so a
>    plain spin_lock is all we need. In i915_irq.c we have the convention
>    to give all such functions an _irq_handler postfix, but that would
>    look strange and als be a bit a misleading name. I've opted for a
>    WARN_ON(!in_irq()) instead.

Hi Daniel,

  Is it possible to use in_interrupt() instead? Sorry to tell that, in
our iGVT-g implementation, the host i915 irq handler needs to be called
in a non hardirq driven context. i.e. a tasklet or workqueue.

  Will send you the RFC patches soon. Just saw a warning after rebased
upon new drm-intel-nightly.

--
Thanks,
Jike




More information about the Intel-gfx mailing list