[Intel-gfx] [PATCH] Revert "drm/i915/bdw: BDW Software Turbo"

[Rodrigo Vivi]

On Mon, Sep 29, 2014 at 9:38 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Mon, Sep 29, 2014 at 08:48:53AM -0700, Jesse Barnes wrote:
>> On Mon, 29 Sep 2014 15:11:51 +0200
>> Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
>>
>> > This reverts commit c76bb61a71083b2d90504cc6d0dda2047c5d63ca.
>> >
>> > It's apparently too broken so that Rodrigo submitted a patch to add a
>> > config option for it. Given that the design is also ... suboptimal and
>> > that I've only merged this to get lead engineers and managers off my
>> > back for one second let's just revert this.
>> >
>> > /me puts on combat gear again
>> >
>> > It was worth a shot ...
>>
>> I thought we had a fix for the runtime PM issue this created?  And
>> Rodrigo's fix is just a simple "only BDW needs this" patch, so I guess
>> I don't see the big issue?

Well, actually the issue is to stay with high busted gt frequency even on idle.
Or this or an incompatibility with the actual rps interface...

So my patch was actually a protect a feture under development with parameter.

>>
>> Or is there another bug you didn't mention in the s-o-b section you're
>> worried about?

The only issue I know is:
References: https://bugs.freedesktop.org/show_bug.cgi?id=77869

>
> Rodrigo's patch seems to set the new sw_turbo module option to 0 by
> default, everywhere.

I believe that protecting the behaviour but accepting the code merged
is a better
approach to convince people to continue contributing by feeling some sense of
progress instead of just blocking all and forcing the constant rebase, etc.
But I won't fight for it mainly because of the original Nack you mentioned.

> So I've figured given Chris' very clear Nack on the
> original patch it's kinda past the point where I can still sugar-coat
> things with a straight enough face.
>
> Or maybe I've totally missing again what's going on.

No, you are right! ;)

> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br