[Intel-gfx] [PATCH 16/59] drm/i915: Add flag to i915_add_request() to skip the cache flush

[Chris Wilson]

On Tue, Mar 31, 2015 at 05:32:07PM +0100, Tomas Elf wrote:
> On 19/03/2015 12:30, John.C.Harrison at Intel.com wrote:
> >From: John Harrison <John.C.Harrison at Intel.com>
> >
> >In order to explcitly track all GPU work (and completely remove the outstanding
> >lazy request), it is necessary to add extra i915_add_request() calls to various
> >places. Some of these do not need the implicit cache flush done as part of the
> >standard batch buffer submission process.
> >
> >This patch adds a flag to _add_request() to specify whether the flush is
> >required or not.

No. Please do cache emission on the request explicitly, do not start
overloading add_request.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre