[Intel-gfx] [PATCH 2/2] drm/i915/vlv: remove wait for previous GFX clk disable request

Jani Nikula jani.nikula at linux.intel.com
Tue Apr 7 06:04:46 PDT 2015


On Thu, 02 Apr 2015, Darren Hart <darren.hart at intel.com> wrote:
> Jesse Barnes <jbarnes <at> virtuousgeek.org> writes:
>> Looks like it was introduced in:
>> 
>> commit 650ad970a39f8b6164fe8613edc150f585315289
>> Author: Imre Deak <imre.deak <at> intel.com>
>> Date:   Fri Apr 18 16:35:02 2014 +0300
>> 
>>     drm/i915: vlv: factor out vlv_force_gfx_clock and check for pending
>>     force-of
>> 
>> but I'm not sure why.  It has caused problems for us in the past (see
>> 85250ddff7a603dfe0ec0503a9e6395f79424f61 and
>> 8d4eee9cd7a170342dc6fbc2ee19ae77031a8cd5) and doesn't seem to be
>> required, so let's just drop it.
>> 
>> References: https://bugs.freedesktop.org/show_bug.cgi?id=89611
>> Signed-off-by: Jesse Barnes <jbarnes <at> virtuousgeek.org>
>
>
> Thanks Jesse,
>
> With this and 1/2 applied I was able to suspend/resume twice in a row
> successfully on a MinnowBoard MAX dual-core (E3825) with the 0.78
> firmware.
>
> Tested-by: Darren Hart <dvhart at linux.intel.com>

Both patches pushed to drm-intel-fixes, along with a cherry-pick of
85250ddff7a6 ("drm/i915/chv: Remove Wait for a previous gfx force-off")
from drm-next to avoid conflicts, all cc: stable. Thanks for the
patches, review, and testing.

BR,
Jani.



>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list