[Intel-gfx] [PATCH] drm/i915: Fix the VBT child device parsing for BSW

[Daniel Vetter]

On Thu, Apr 09, 2015 at 11:56:36AM +0100, Damien Lespiau wrote:
> On Thu, Apr 09, 2015 at 01:37:10PM +0300, Ville Syrjälä wrote:
> > On Thu, Apr 09, 2015 at 09:49:25AM +0100, Damien Lespiau wrote:
> > > On Wed, Mar 25, 2015 at 06:45:58PM +0200, ville.syrjala at linux.intel.com wrote:
> > > > +static union child_device_config *
> > > > +child_device_ptr(struct bdb_general_definitions *p_defs, int i)
> > > > +{
> > > > +	return (void *) &p_defs->devices[i * p_defs->child_dev_size];
> > > > +}
> > > 
> > > Actually this looks wrong. We're doing:
> > > 
> > >   p_defs->devices + sizeof(union child_device_config) * i * child_dev_size
> > > 
> > > instead of:
> > > 
> > >   (u8)p_defs->devices + i * child_dev_size
> > > 
> > > ?
> > 
> > The patch also had:
> > -     union child_device_config devices[0];
> > +     uint8_t devices[0];
> 
> Ah, yes! oops

With the r-b reinstantiated I merged the patch, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch