[Intel-gfx] [PATCH 09/11] xf86drmSL: Check memory allocation by SL_RANDOM_INIT()

Praveen Paneri praveen.paneri at intel.com
Fri Apr 10 01:43:01 PDT 2015


If the allocation fails, return -ENOMEM. Handle the return value
at the caller funtion drmSLInsert() as well.

v2: Rebased to the latest.

Signed-off-by: Praveen Paneri <praveen.paneri at intel.com>
---
 xf86drmSL.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xf86drmSL.c b/xf86drmSL.c
index 42b5bc4..3ceb087 100644
--- a/xf86drmSL.c
+++ b/xf86drmSL.c
@@ -40,6 +40,7 @@
 
 #include <stdio.h>
 #include <stdlib.h>
+#include <errno.h>
 
 #include "xf86drm.h"
 
@@ -92,6 +93,7 @@ static int SLRandomLevel(void)
     SL_RANDOM_DECL;
 
     SL_RANDOM_INIT(SL_RANDOM_SEED);
+    if (!state) return -ENOMEM;
     
     while ((SL_RANDOM & 0x01) && level < SL_MAX_LEVEL) ++level;
     return level;
@@ -168,6 +170,9 @@ int drmSLInsert(void *l, unsigned long key, void *value)
 
 
     level = SLRandomLevel();
+    if (level < 0)
+	return level;
+
     if (level > list->level) {
 	level = ++list->level;
 	update[level] = list->head;
-- 
1.9.1



More information about the Intel-gfx mailing list