[Intel-gfx] [PATCH 63/70] drm/i915: Reduce locking inside swfinish ioctl

Daniel Vetter daniel at ffwll.ch
Fri Apr 10 02:14:56 PDT 2015


On Tue, Apr 7, 2015 at 6:28 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
>         /* Pinned buffers may be scanout, so flush the cache */
> -       if (obj->pin_display)
> +       if (obj->pin_display) {
> +               ret = i915_mutex_lock_interruptible(dev);
> +               if (ret)
> +                       goto unref;

I think and ACCESS_ONCE here and in the previous one would be good.
Wanted to do that and merge both, but they seem to conflict with the
lack of read-read ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Intel-gfx mailing list