[Intel-gfx] [PATCH 34/49] drm/i915/bxt: Restrict PORT_CLK_SEL programming below gen9

[Imre Deak]

On ma, 2015-04-13 at 14:21 +0100, Damien Lespiau wrote:
> On Sun, Apr 12, 2015 at 03:52:12PM +0530, sagar.a.kamble at intel.com wrote:
> > For patch at http://lists.freedesktop.org/archives/intel-gfx/2015-March/062169.html
> > Reviewed-by: Sagar Kamble <sagar.a.kamble at intel.com>
> 
> Usually reviews are done as a reply to the patch, but maybe you didn't
> receive the earlier mail?
> 
> -		I915_WRITE(PORT_CLK_SEL(port),
> -			   intel_crtc->config->ddi_pll_sel);
> +		/* FIXME: add support for SKL */
> +		if (!INTEL_INFO(dev)->gen < 9)
> +			I915_WRITE(PORT_CLK_SEL(port),
> +				   intel_crtc->config->ddi_pll_sel);
>  
> This '!' looks fishy to me.

Yes, that's a typo from me. Will fix it, thanks for catching it.

--Imre