[Intel-gfx] [PATCH v3 3/8] drm/i915/skl: Add DC5 Trigger Sequence

Damien Lespiau damien.lespiau at intel.com
Mon Apr 13 08:25:47 PDT 2015


On Mon, Apr 13, 2015 at 03:56:23PM +0530, Animesh Manna wrote:
> @@ -71,6 +90,8 @@ void intel_csr_load_program(struct drm_device *dev)
>  		I915_WRITE(dev_priv->csr.mmioaddr[i],
>  			dev_priv->csr.mmiodata[i]);
>  	}
> +
> +	intel_csr_load_status_set(dev_priv, FW_LOADED);
>  	mutex_unlock(&dev_priv->csr_lock);
>  }

This doesn't look correct: you're already inside a section with csr_lock
taken, intel_csr_load_status_set() tries to take csr_lock and mutexes
aren't recursive.

-- 
Damien


More information about the Intel-gfx mailing list