[Intel-gfx] [PATCH] drm/i915: add psr toggle to debugfs

[Rodrigo Vivi]

On Mon, Apr 20, 2015 at 8:41 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Thu, Apr 16, 2015 at 09:10:11AM -0700, Eric Caruso wrote:
>> On Thu, Apr 16, 2015 at 8:58 AM, Rodrigo Vivi <rodrigo.vivi at gmail.com> wrote:
>> > I'm not sure that that property will be accepted...
>> > if so it can be changed to toggle, but for now it is informative only
>> > (DRM_MODE_PROP_IMMUTABLE).
>> >
>>
>> Okay, that changes things somewhat. There'll have to be some discussion over
>> what the sysfs interface would be, then. It's supposed to be stable, if I
>> understand correctly.
>
> Imo if it's just for debugging, then debugfs is the correct place. Sysfs
> means ABI with all the requirements (igt tests, open-source userspace,
> ...) that entails.

Good points, so:
Acked-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

Although "i915.enable_psr = enable;" is useless and change the meaning
of this parameter.
I'd remove this...

And probably check for  pipe_config psr ready if/when merged...

> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br