[Intel-gfx] [PATCH] drm/i915: Don't read dpcd for disconnected ports

Mika Kuoppala mika.kuoppala at linux.intel.com
Tue Apr 21 00:20:29 PDT 2015


Reading from disconnected ports will spit out timeout error
on the dmesg. Skip the attempted read if the port is not
connected and avoid confusing users/testcases about
expected timeouts.

This new dpcd debugfs entry was introduced by commit aa7471d228eb
("drm/i915: add i915 specific connector debugfs file for DPCD")

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90060
Tested-by: yex.tian at intel.com
Cc: Jani Nikula <jani.nikula at intel.com>
Cc: Bob Paauwe <bob.j.paauwe at intel.com>
Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 9c2b9e4..fbc1f39 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -4938,6 +4938,9 @@ static int i915_dpcd_show(struct seq_file *m, void *data)
 		    connector->connector_type != DRM_MODE_CONNECTOR_eDP)
 			continue;
 
+		if (connector->status != connector_status_connected)
+			continue;
+
 		/* low tech for now */
 		if (WARN_ON(size > sizeof(buf)))
 			continue;
-- 
1.9.1



More information about the Intel-gfx mailing list