[Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

Chris Wilson chris at chris-wilson.co.uk
Tue Apr 21 02:51:42 PDT 2015


On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Avoids duplicating the code.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Sonika Jindal <sonika.jindal at intel.com>
> Cc: Damien Lespiau <damien.lespiau at intel.com>
> ---
> Can we do this?

Sure, but I'd like to see update_primary_plane split into two in that
case. One to precalcuate the parameters, then the second to apply them
as we skip the first here (due to doing the setup in process context)
and want the second to run inside the vblank evasion logic (and the
unbounded nature of the current update_primary_plane logic scares me).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list