[Intel-gfx] [PATCH] drm/i915: fix for_each_digital_port

Damien Lespiau damien.lespiau at intel.com
Mon Apr 27 10:18:42 PDT 2015


On Mon, Apr 27, 2015 at 06:15:45PM +0100, Damien Lespiau wrote:
> On Mon, Apr 27, 2015 at 06:05:31PM +0100, Damien Lespiau wrote:
> > On Fri, Apr 17, 2015 at 02:58:10PM +0300, Imre Deak wrote:
> > > We should check if a given encoder is of a digital type before casting
> > > it to a digital port object. This broke on HSW when iterating the VGA
> > > encoder.
> > > 
> > > Introduced in
> > > commit b403745c84592b26a0713e6944c2b109f6df5c82
> > > Author: Damien Lespiau <damien.lespiau at intel.com>
> > > Date:   Mon Aug 4 22:01:33 2014 +0100
> > > 
> > >     drm/i915: Iterate through the initialized DDIs to prepare their buffers
> > > 
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90067
> > > Signed-off-by: Imre Deak <imre.deak at intel.com>
> > 
> > Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>
> 
> Huuum, scrap that r-b, I think we're missing PORT_E initialization on
> HSW, because that's the one driver the CRT encoder through FDI.

Which is exactly what Paulo found as well... Did we already mentionned
how hard is was to follow reviews :)

-- 
Damien


More information about the Intel-gfx mailing list