[Intel-gfx] [PATCH v2] drm/i915: Avoid GPU hang when coming out of S3 or S4
David Weinehall
david.weinehall at linux.intel.com
Wed Apr 29 04:07:19 PDT 2015
On Tue, Apr 28, 2015 at 03:46:46PM +0100, Chris Wilson wrote:
> On Tue, Apr 28, 2015 at 02:38:25PM +0000, Antoine, Peter wrote:
> > So is the plan to push these patches and have follow-on work to cover the other paths?
> > As this fixes the Bugzilla issue that has been raised.
>
> You've identified an issue, but I think your patch is incomplete.
I've tried my best to go through the remaining similar-looking code,
but the rest seems fine (I might've missed something though).
The only thing I reacted on was that in intel_runtime_resume() the call
to intel_init_pch_refclk() is conditional on IS_GEN6(), but none of the
other invocations of intel_init_pch_refclk() are. The commit message
doesn't seem to provide a sufficient explanation for why this is so.
Regards, David
More information about the Intel-gfx
mailing list