[Intel-gfx] [PATCH] drm/i915/gen9: Update null batch to follow VF state restriction

Ben Widawsky benjamin.widawsky at intel.com
Tue Aug 4 18:37:27 PDT 2015


On Fri, Jul 31, 2015 at 04:28:45PM +0100, Arun Siluvery wrote:
> Atleast one component of one valid vertex element must be enabled.
> 
> Cc: Ben Widawsky <benjamin.widawsky at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Arun Siluvery <arun.siluvery at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_renderstate_gen9.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_renderstate_gen9.c b/drivers/gpu/drm/i915/intel_renderstate_gen9.c
> index 16a7ec2..fa86431 100644
> --- a/drivers/gpu/drm/i915/intel_renderstate_gen9.c
> +++ b/drivers/gpu/drm/i915/intel_renderstate_gen9.c
> @@ -873,7 +873,7 @@ static const u32 gen9_null_state_batch[] = {
>  	0x00000000,
>  	0x00000000,
>  	0x78550003,
> -	0x00000000,
> +	0x00000001,
>  	0x00000000,
>  	0x00000000,
>  	0x00000000,

Same as previous comment in patch 1, but silly programming is better than
definitely incorrect programming. With the comments from 1 addressed:
Reviewed-by: Ben Widawsky <ben at bwidawsk.net>

-- 
Ben Widawsky, Intel Open Source Technology Center


More information about the Intel-gfx mailing list