[Intel-gfx] [PATCH v6 15/19] drm/i915: batch_obj vm offset must be u64

Daniel Vetter daniel at ffwll.ch
Thu Aug 6 05:30:56 PDT 2015


On Wed, Aug 05, 2015 at 05:14:03PM +0100, Michel Thierry wrote:
> On 8/5/2015 5:01 PM, Daniel Vetter wrote:
> >On Wed, Jul 29, 2015 at 05:23:59PM +0100, Michel Thierry wrote:
> >>Otherwise it can overflow in 48-bit mode, and cause an incorrect
> >>exec_start.
> >>
> >>Before commit 5f19e2bffa63a91cd4ac1adcec648e14a44277ce ("drm/i915: Merged
> >>the many do_execbuf() parameters into a structure"), it was already an u64.
> >>
> >>Signed-off-by: Michel Thierry <michel.thierry at intel.com>
> >
> >So we have a few more u64, but the i915_gem_obj_offset is still unsigned
> >long. Am I missing a patch?
> 
> http://news.gmane.org/find-root.php?message_id=1437063498-31930-1-git-send-email-michel.thierry@intel.com
> 
> Which I need to re-send with the comments I got.
> Thanks for remind me.

Process reminder: If your patch series has depencies either
- include them at the start (git will correctly keep authorship), which is
  the preferred approach
- or at least mention your depencies in the cover letter

Relying on your maintainer's mind-reader to figure this out doesn't scale ;-)

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list