[Intel-gfx] Enable PSR in IvyBridge?

[harrykipper]

Hello,

I just discovered that Intel introduced PSR with IvyBridge, so I tried 
to enable it for my laptop, which has an eDP panel that supports psr. 
The patch is attached (all I do is enable all things IvyBridge, I am 
not familiar with the kernel at all, apologies if you see absurdities).

However, I had *some* success, I have:

Sink_Support: yes
Source_OK: yes
Enabled: yes
Active: yes
Busy frontbuffer bits: 0x000
Re-enable work scheduled: no
HW Enabled & Active bit: no
Link standby: no
Performance_Counter: 0

and so far I am only seeing one error, whenever the screen is turned 
on/off (at boot and when gnome blanks it to save power, for example). 
All the problems seem to be in intel_psr_exit() and intel_psr_flush(). 
I read in Rodrigo Vivi's blog that a psr test should exist in 
intel-gpu-tools, but I couldn't find it.

I am inclined to think that enabling psr for IvyBridge shouldn't be too 
hard for someone who knows what they are doing. If someone wants to 
take this on I will be happy to test and report bugs, although my 
hardware is fairly bizarre.

Best regards

 ------------[ cut here ]------------
kernel: WARNING: CPU: 3 PID: 726 at 
drivers/gpu/drm/i915/intel_psr.c:532 intel_psr_exit+0x152/0x160()
kernel: WARN_ON(!(val & EDP_PSR_ENABLE))
kernel: Modules linked in:
kernel:  fuse acpi_call(O) nls_iso8859_15 nls_cp850 vfat fat 
snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_cod
kernel: CPU: 3 PID: 726 Comm: Xorg Tainted: G     U     O    4.1.4-eDP 
#1
kernel: Hardware name: LENOVO 2324B14/2324B14, BIOS G2ETA3WW (2.63 ) 
02/05/2015
kernel:  ffffffff81718e70 000000000bfa939c ffffffff81718e70 
ffffffff815b820b
kernel:  ffff8800c50d7c50 ffffffff810709a7 ffff8802146c0000 
0000000000000000
kernel:  ffff880214a4a800 0000000000000000 ffff880214a4a800 
ffffffff81070a38
kernel: Call Trace:
kernel:  [<ffffffff815b820b>] ? dump_stack+0x47/0x67
kernel:  [<ffffffff810709a7>] ? warn_slowpath_common+0x77/0xb0
kernel:  [<ffffffff81070a38>] ? warn_slowpath_fmt+0x58/0x80
kernel:  [<ffffffff813c3ec2>] ? intel_psr_exit+0x152/0x160
kernel:  [<ffffffff813c4bf2>] ? intel_psr_invalidate+0x42/0x70
kernel:  [<ffffffff813c1268>] ? intel_fb_obj_invalidate+0xa8/0x110
kernel:  [<ffffffff8137bf07>] ? 
i915_gem_object_set_to_gtt_domain+0x127/0x150
kernel:  [<ffffffff8137ff33>] ? i915_gem_fault+0x1e3/0x3f0
kernel:  [<ffffffff811291ba>] ? __do_fault+0x4a/0xe0
kernel:  [<ffffffff811600e0>] ? __mem_cgroup_count_vm_event+0x10/0x70
kernel:  [<ffffffff8112d2f8>] ? handle_mm_fault+0x438/0x15b0
kernel:  [<ffffffff811899b3>] ? __fget+0x63/0xa0
kernel:  [<ffffffff8107a575>] ? recalc_sigpending+0x15/0x50
kernel:  [<ffffffff8107b1b8>] ? __set_task_blocked+0x38/0x90
kernel:  [<ffffffff8103f798>] ? __do_page_fault+0x158/0x3d0
kernel:  [<ffffffff8107db09>] ? SyS_rt_sigprocmask+0x89/0xd0
kernel:  [<ffffffff815c0342>] ? page_fault+0x22/0x30
kernel: ---[ end trace cb3b5b396afe8d4e ]---


-------------- next part --------------
A non-text attachment was scrubbed...
Name: ivy-psr.patch
Type: text/x-patch
Size: 5087 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20150806/6f966f8d/attachment.bin>