[Intel-gfx] [drm-intel:for-linux-next 479/497] drivers/gpu/drm/i915/i915_gem_gtt.c:1086:26: sparse: Using plain integer as NULL pointer

Daniel Vetter daniel.vetter at ffwll.ch
Thu Aug 6 15:00:31 PDT 2015


On Thu, Aug 6, 2015 at 10:17 PM, kbuild test robot
<fengguang.wu at intel.com> wrote:
>   1070          if (IS_ENABLED(CONFIG_X86_32))
>   1071                  /* While we have a proliferation of size_t variables
>   1072                   * we cannot represent the full ppgtt size on 32bit,
>   1073                   * so limit it to the same size as the GGTT (currently
>   1074                   * 2GiB).
>   1075                   */
>   1076                  ppgtt->base.total = to_i915(ppgtt->base.dev)->gtt.base.total;
>   1077          ppgtt->base.cleanup = gen8_ppgtt_cleanup;
>   1078          ppgtt->base.allocate_va_range = gen8_alloc_va_range;
>   1079          ppgtt->base.insert_entries = gen8_ppgtt_insert_entries;
>   1080          ppgtt->base.clear_range = gen8_ppgtt_clear_range;
>   1081          ppgtt->base.unbind_vma = ppgtt_unbind_vma;
>   1082          ppgtt->base.bind_vma = ppgtt_bind_vma;
>   1083
>   1084          ppgtt->switch_mm = gen8_mm_switch;
>   1085
>> 1086          ret = __pdp_init(false, &ppgtt->pdp);

So the first argument of pdp_init ist struct drm_device *dev and yes
the first thing it does is deref it.

How exactly was this tested again?

Oh and the hunk right below with the CONFIG_X86_32 needs to got too -
if we're 48b safe then we should be 32b safe too ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Intel-gfx mailing list