[Intel-gfx] [PATCH 1/2] drm/i915: Adding break for one case

[Zhang, Xiong Y]

> On Thu, Aug 13, 2015 at 01:37:49PM +0300, Timo Aaltonen wrote:
> > On 13.08.2015 13:36, Timo Aaltonen wrote:
> > > On 13.08.2015 13:00, Xiong Zhang wrote:
> > >> Signed-off-by: Xiong Zhang <xiong.y.zhang at intel.com>
> > >> ---
> > >>  drivers/gpu/drm/i915/intel_display.c | 1 +
> > >>  1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/drivers/gpu/drm/i915/intel_display.c
> > >> b/drivers/gpu/drm/i915/intel_display.c
> > >> index 65cc5b1..801187c 100644
> > >> --- a/drivers/gpu/drm/i915/intel_display.c
> > >> +++ b/drivers/gpu/drm/i915/intel_display.c
> > >> @@ -1100,6 +1100,7 @@ bool ibx_digital_port_connected(struct
> drm_i915_private *dev_priv,
> > >>  			break;
> > >>  		case PORT_E:
> > >>  			bit = SDE_PORTE_HOTPLUG_SPT;
> > >> +			break;
> > >>  		default:
> > >>  			return true;
> > >>  		}
> > >>
> > >
> > > shouldn't this belong to [5/6]?
> >
> > Nevermind, I see now that it got merged already.
> 
> I dropped that patch again so that we can rectify this properly. Jani's complaint
> about the sub-par commit message still holds though, like why was this not
> caught in testing?
[Zhang, Xiong Y] Yes, it's better to drop it. I will explain it the commit message and resent the patch.
> -Daniel