[Intel-gfx] [PATCH v2 3/7] drm/i915: add MISSING_CASE annotation to ibx_digital_port_connected
Jani Nikula
jani.nikula at intel.com
Thu Aug 20 00:47:38 PDT 2015
With the case added for eDP on port A (always connected from this
function's point of view), we should not be hitting any of the default
cases in ibx_digital_port_connected, so add MISSING_CASE annotation.
Signed-off-by: Jani Nikula <jani.nikula at intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index d35dc0711f9b..f08859471841 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4487,6 +4487,8 @@ static bool ibx_digital_port_connected(struct drm_i915_private *dev_priv,
if (HAS_PCH_IBX(dev_priv->dev)) {
switch (port->port) {
+ case PORT_A:
+ return true;
case PORT_B:
bit = SDE_PORTB_HOTPLUG;
break;
@@ -4497,10 +4499,13 @@ static bool ibx_digital_port_connected(struct drm_i915_private *dev_priv,
bit = SDE_PORTD_HOTPLUG;
break;
default:
- return true;
+ MISSING_CASE(port->port);
+ return false;
}
} else {
switch (port->port) {
+ case PORT_A:
+ return true;
case PORT_B:
bit = SDE_PORTB_HOTPLUG_CPT;
break;
@@ -4511,7 +4516,8 @@ static bool ibx_digital_port_connected(struct drm_i915_private *dev_priv,
bit = SDE_PORTD_HOTPLUG_CPT;
break;
default:
- return true;
+ MISSING_CASE(port->port);
+ return false;
}
}
--
2.1.4
More information about the Intel-gfx
mailing list