[Intel-gfx] Still time for v4.2? - c0165304e10f ("drm/i915: Only enable cursor if it can be enabled.")

[Bjørn Mork]

Maarten Lankhorst <maarten.lankhorst at linux.intel.com> writes:

> Hey,
>
> Op 25-08-15 om 09:45 schreef Bjørn Mork:
>> Hello, I see that I consistently get the warning below on v4.2-rc8.  I
>> believe you already fixed this a long time ago by commit c0165304e10f
>> ("drm/i915: Only enable cursor if it can be enabled."), which I assume is
>> a stable candidate for v4.2.y.
>>
>> But wouldn't it look better if you managed to squeeze this into v4.2?
>> The warning will probably cause a few unnecessary worries and reports
>> from users...
>>
>> Sample WARNING from v4.2-rc8, minus the irrelevant list of modules:
>> ------------[ cut here ]------------
>> WARNING: CPU: 1 PID: 2675 at drivers/gpu/drm/i915/intel_display.c:9669 intel_crtc_update_cursor+0x335/0x452 [i915]()
>> Missing switch case (0) in i9xx_update_cursor
>> CPU: 1 PID: 2675 Comm: Xorg Tainted: G        W       4.2.0-rc8 #339
>> Hardware name: LENOVO 2776LEG/2776LEG, BIOS 6EET55WW (3.15 ) 12/19/2011
>>  0000000000000009 ffff88022ca07b68 ffffffff81423887 0000000000000006
>>  ffff88022ca07bb8 ffff88022ca07ba8 ffffffff8104a9d6 0000000000070088
>>  ffffffffa036b141 ffff8802317c9000 000000000053e000 ffff880231790000
> What are you doing that triggers this? Works for me on v4.2..

That's a really good question.  I saw the warnings a couple of times
after resuming from suspend (S3) and made a too hasty assumption that
resuming would always trigger it.

But now that I'm trying to provoke it, I cannot reproduce it whatever I
do...

FWIW, my suspend scripts run "xscreensaver-command -lock" to make sure
the screen is at least locked if someone else should wake the PC, and
xscreensaver is set up to blank and power off the screen.  I don't know
if this affects the results.


Bjørn