[Intel-gfx] [PATCH] drm/i915: Unhook legacy suspend/resume when KMS is enabled

Patrik Jakobsson patrik.r.jakobsson at gmail.com
Tue Aug 25 11:22:00 PDT 2015


On Tue, Aug 25, 2015 at 6:41 PM, Jani Nikula
<jani.nikula at linux.intel.com> wrote:
> On Tue, 25 Aug 2015, Daniel Vetter <daniel at ffwll.ch> wrote:
>> On Tue, Aug 25, 2015 at 10:51:10AM +0200, Patrik Jakobsson wrote:
>>> It's not allowed to have legacy suspend/resume hooked up when
>>> DRIVER_MODESET is set. Doing so results in a warning introduced by the
>>> commit below.
>>>
>>> commit e8b4855b5dd3e285d0ec18ed15468025abc1be9a
>>> Author: Gustavo Padovan <gustavo.padovan at collabora.co.uk>
>>> Date:   Thu Aug 13 17:06:39 2015 -0300
>>>
>>>     drm: WARN_ON if a modeset driver uses legacy suspend/resume helpers
>>>
>>>     Legacy s/r hooks are only used for shadow-attaching drivers, warn
>>>     when a KMS driver tries to use them.
>>>
>>>     Signed-off-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk>
>>>     Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>>>
>>> Signed-off-by: Patrik Jakobsson <patrik.jakobsson at linux.intel.com>
>>
>> There is no legacy KMS any more, please just kill the hooks entirely.
>
> http://mid.gmane.org/55D1B0C6.3030906@linux.intel.com
>
> BR,
> Jani.

Perfect, pick that one. Any reason why it's not merged yet?

-Patrik


More information about the Intel-gfx mailing list