[Intel-gfx] [PATCH] Fix list empty check in i915_gem_evict_everything

[Zhiyuan Lv]

Hi Chris,

Thanks for the reply! Do you mean we could completely delete
i915_gem_evict_everything() and rely on others to do gem_retire_requests()?
Sorry that I am still learning the code :-)

Regards,
-Zhiyuan

On Wed, Aug 26, 2015 at 08:28:43AM +0100, Chris Wilson wrote:
> On Wed, Aug 26, 2015 at 03:01:26PM +0800, Zhiyuan Lv wrote:
> > That seems to be a typo. The original code will override the previous
> > list empty check value in the loop. As the result, only the last vm in
> > vm_list impacts the empty check. The problem is fixed by using local
> > bool variable inside the loop.
> 
> Or we could just delete the code entirely since it is no longer used
> (except for a mistake in shrink-all).
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre