[Intel-gfx] [PATCH 1/3] drm/i915: Support for pre-populating the object with system pages

Chris Wilson chris at chris-wilson.co.uk
Thu Aug 27 00:45:35 PDT 2015


On Thu, Aug 27, 2015 at 11:18:15AM +0530, Ankitprasad Sharma wrote:
> On Mon, 2015-08-24 at 13:35 +0100, Chris Wilson wrote:
> > I am tempted to say this should be in a new
> > 
> > __i915_gem_object_get_pages__tail_locked()
> > 
> > so that we don't have to hunt down users if we ever need to modify the
> > global lists.
> Could not get you here. 
> is it just to add list_add_tail in a separate function
> __i915_gem_object_get_pages__tail_locked(),

Yes. It's just a preventative maintenance step for when we need something
other than just adding the object to the global list. I would rather not
have core state tracking dotted around random callers.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list