[Intel-gfx] [PATCH 09/11] drm/i915: LPT:LP needs port A HPD enabled in both north and south

Paulo Zanoni przanoni at gmail.com
Thu Aug 27 11:40:34 PDT 2015


2015-08-12 12:44 GMT-03:00  <ville.syrjala at linux.intel.com>:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Supposedly we have to enable port A HPD also in the south on LPT:LP.

The correctness of this patch is going to be decided by the discussion
of patch 5, and up to this moment the answer we have is not 100%
precise.

If (conclusion == "CPU and PCH are in the same package _if and only
if_ HAS_PCH_LPT_LP")
    Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_irq.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index d994b80..de60174 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3125,6 +3125,8 @@ static void ibx_hpd_irq_setup(struct drm_device *dev)
>         hotplug |= PORTD_HOTPLUG_ENABLE | PORTD_PULSE_DURATION_2ms;
>         hotplug |= PORTC_HOTPLUG_ENABLE | PORTC_PULSE_DURATION_2ms;
>         hotplug |= PORTB_HOTPLUG_ENABLE | PORTB_PULSE_DURATION_2ms;
> +       if (HAS_PCH_LPT_LP(dev))
> +               hotplug |= PORTA_HOTPLUG_ENABLE;
>         I915_WRITE(PCH_PORT_HOTPLUG, hotplug);
>  }
>
> --
> 2.4.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni


More information about the Intel-gfx mailing list