[Intel-gfx] [PATCH i-g-t 1/3] tests/kms_force_connector: Fixes

[Daniel Vetter]

On Tue, Dec 01, 2015 at 10:11:14AM +0000, Thomas Wood wrote:
> On 1 December 2015 at 08:08, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > Two things:
> > - Somehow the kernel's mode list changed with our EDID. No idea
> >   whether that's the right thing here since I'm not really an EDID
> >   expert. But then again the testcase wants to check that the
> >   injection works, not validate the kernel's parser.
> 
> If only checking that the injection worked, perhaps it would be more
> robust just to check that at least one of the expected modes is
> present, in any position in the array. Ideally this would be a mode
> that isn't included in the default modes when a connector is enabled.

One option would be to check for the 1920x1080 mode only. That's the
preferred one, so really must be first. And it's way more high-res than
any of the default modes we inject (those top out at 1024x768). Ok with
that?

> > - We need to disable the forcing _before_ we reprobe to check whether
> >   everything is back to normal: With the EDID gone but the connection
> >   still force to on the kernel will fall back to a default low-res
> >   mode list, making the testcase fail.
> 
> This should be taken into account with the value of start_n_modes,
> since this is calculated after the connector is enabled.

Oops, I did accidentally break this in my GetConnectorCurrent patch, since
there I consolidated them all to avoid overhead. And didn't notice
because of the earlier breakage.

I'll respin these two and shift the 2nd change to the 2nd patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch