[Intel-gfx] [PATCH i-g-t] tests/pm_rpm: Don't compare edid blob IDs

[Paulo Zanoni]

2015-12-01 14:37 GMT-02:00 Daniel Vetter <daniel.vetter at ffwll.ch>:
> The kernel is free to allocate blob ids however it wants to. And also
> to reallocate them whenever it sees fit. The only thing we are allowed
> to compare is the length and the actual date.
>
> Removing this bogus check makes drm-resources-equal on my snb.

The main question here is: why did this work reliably before?

>
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>  tests/pm_rpm.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index 37aef96ed267..55fdb31cb723 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -512,7 +512,6 @@ static void assert_drm_edids_equal(drmModePropertyBlobPtr e1,
>                 return;
>         igt_assert(e1 && e2);
>
> -       COMPARE(e1, e2, id);
>         COMPARE(e1, e2, length);
>
>         igt_assert(memcmp(e1->data, e2->data, e1->length) == 0);
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni