[Intel-gfx] [PATCH v2 04/10] drm/i915: Add "missing" break to haswell_get_ddi_pll()

Ville Syrjälä ville.syrjala at linux.intel.com
Wed Dec 2 01:29:10 PST 2015


On Tue, Dec 01, 2015 at 11:32:07PM +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> While not technically needed on the last case in the switch statement,
> the 'break' makes it look better IMO.
> 
> v2: Fixed a typo in the commit message (Paulo)
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 9f8ab09eb411..edc034dc38b2 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9808,6 +9808,7 @@ static void haswell_get_ddi_pll(struct drm_i915_private *dev_priv,
>  		break;
>  	case PORT_CLK_SEL_SPLL:
>  		pipe_config->shared_dpll = DPLL_ID_SPLL;
> +		break;
>  	}
>  }

Merged up to this patch. Thanks for the reviews.

-- 
Ville Syrjälä
Intel OTC


More information about the Intel-gfx mailing list