[Intel-gfx] [PATCH 12/29] drm/armada: Drop struct_mutex from cursor paths

Daniel Vetter daniel at ffwll.ch
Thu Dec 3 23:51:35 PST 2015


On Thu, Dec 03, 2015 at 04:08:45PM +0000, Russell King - ARM Linux wrote:
> On Mon, Nov 23, 2015 at 10:32:45AM +0100, Daniel Vetter wrote:
> > @@ -957,11 +955,9 @@ static int armada_drm_crtc_cursor_move(struct drm_crtc *crtc, int x, int y)
> >  	if (!dcrtc->variant->has_spu_adv_reg)
> >  		return -EFAULT;
> >  
> > -	mutex_lock(&dev->struct_mutex);
> >  	dcrtc->cursor_x = x;
> >  	dcrtc->cursor_y = y;
> >  	ret = armada_drm_crtc_cursor_update(dcrtc, false);
> > -	mutex_unlock(&dev->struct_mutex);
> >  
> >  	return ret;
> >  }
> 
> drivers/gpu/drm/armada/armada_crtc.c: In function 'armada_drm_crtc_cursor_move':
> drivers/gpu/drm/armada/armada_crtc.c:916:21: warning: unused variable 'dev' [-Wunused-variable]
> 
> Shall I add to your patch a change to remove that variable too? :)

Yes please ;-) I guess I should stop relying on 0-day for arm builds and
set up a proper arm toolchain again (the old one went to waste a bit).

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list