[Intel-gfx] [PATCH 4/4] fbdev: Debug knob to register without holding console_lock
tomi.valkeinen at ti.com
Mon Dec 7 09:32:42 PST 2015
On 25/08/15 16:45, Daniel Vetter wrote:
> When the usual fbcon legacy options are enabled we have
> ->fb notifier chain calls into fbcon
> ->fbcon sets up console on new fbi
> ->drm_fb_helper_set_par exercises full kms api
> And because of locking inversion hilarity all of register_framebuffer
> is done with the console lock held. Which means that the first time on
> driver load we exercise _all_ the kms code (all probe paths and
> modeset paths for everything connected) is under the console lock.
> That means if anything goes belly-up in that big pile of code nothing
> ever reaches logfiles (and the machine is dead).
> Usual tactic to debug that is to temporarily remove those console_lock
> calls to be able to capture backtraces. I'm fed up writing this patch
> and recompiling kernels. Hence this patch here to add an unsafe,
> kernel-taining option to do this at runtime.
I think this was never merged. This was part 4 of 4, were there
dependencies or...? Should I apply this for 4.5?
But then... I think my issues with console lock have been later at
runtime, not at register. Maybe we need a module option to disable the
console lock altogether. I wonder how much havoc that might create, though.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: OpenPGP digital signature
More information about the Intel-gfx