[Intel-gfx] [PATCH v4 00/14] drm: Give crtcs and planes actual names (v4)

ville.syrjala at linux.intel.com ville.syrjala at linux.intel.com
Tue Dec 8 08:41:48 PST 2015


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

I've done some more modeset log staring recently and again got
fed up with the noise. So here's another attempt at making the
logs make some sense.

This time I pass a printf style format string to the init functions, so
that callers don't have to worry about any snprintf buffers or memory
allocation.

Also if the caller passes in NULL, the core will fill out some kind of
default value ("crtc-%d", "plane-%d", etc.).

I also made it possible for drivers to supply the name for encoders.
Eg. "HDMI B" tells me much more on intel hardware than "TMDS-<random number>".

Previous attempts:
http://lists.freedesktop.org/archives/dri-devel/2015-November/094331.html
http://lists.freedesktop.org/archives/dri-devel/2015-November/094359.html
http://lists.freedesktop.org/archives/dri-devel/2015-November/094425.html

Entire series available here:
git://github.com/vsyrjala/linux.git crtc_plane_name_4

Ville Syrjälä (14):
  drm: Pass 'name' to drm_crtc_init_with_planes()
  drm: Pass 'name' to drm_universal_plane_init()
  drm: Pass 'name' to drm_encoder_init()
  drm: Use driver specified encoder name
  drm: Add crtc->name and use it in debug messages
  drm: Add plane->name and use it in debug prints
  drm/i915: Use crtc->name in debug messages
  drm/i915: Use plane->name in debug prints
  drm/i915: Set crtc->name to "pipe A", "pipe B", etc.
  drm/i915: Fix plane init failure paths
  drm/i915: Don't leak primary/cursor planes on crtc init failure
  drm/i915: Give meaningful names to all the planes
  drm/i915: Give encoders useful names
  drm/i915: Add debug prints for encoder modeset hooks

 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c           |  14 +-
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c           |  14 +-
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c            |  14 +-
 drivers/gpu/drm/armada/armada_crtc.c             |   4 +-
 drivers/gpu/drm/armada/armada_overlay.c          |   2 +-
 drivers/gpu/drm/ast/ast_mode.c                   |   2 +-
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c   |   2 +-
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c |   2 +-
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c  |   2 +-
 drivers/gpu/drm/bochs/bochs_kms.c                |   2 +-
 drivers/gpu/drm/cirrus/cirrus_mode.c             |   2 +-
 drivers/gpu/drm/drm_atomic.c                     |  53 ++---
 drivers/gpu/drm/drm_atomic_helper.c              |  60 +++---
 drivers/gpu/drm/drm_crtc.c                       |  91 ++++++++-
 drivers/gpu/drm/drm_crtc_helper.c                |  24 ++-
 drivers/gpu/drm/drm_plane_helper.c               |   5 +-
 drivers/gpu/drm/exynos/exynos_dp_core.c          |   2 +-
 drivers/gpu/drm/exynos/exynos_drm_crtc.c         |   2 +-
 drivers/gpu/drm/exynos/exynos_drm_dpi.c          |   2 +-
 drivers/gpu/drm/exynos/exynos_drm_dsi.c          |   2 +-
 drivers/gpu/drm/exynos/exynos_drm_plane.c        |   2 +-
 drivers/gpu/drm/exynos/exynos_drm_vidi.c         |   2 +-
 drivers/gpu/drm/exynos/exynos_hdmi.c             |   2 +-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c       |   2 +-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c      |   2 +-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c        |   2 +-
 drivers/gpu/drm/gma500/cdv_intel_crt.c           |   2 +-
 drivers/gpu/drm/gma500/cdv_intel_dp.c            |   3 +-
 drivers/gpu/drm/gma500/cdv_intel_hdmi.c          |   2 +-
 drivers/gpu/drm/gma500/cdv_intel_lvds.c          |   2 +-
 drivers/gpu/drm/gma500/mdfld_dsi_dpi.c           |   2 +-
 drivers/gpu/drm/gma500/oaktrail_hdmi.c           |   2 +-
 drivers/gpu/drm/gma500/oaktrail_lvds.c           |   2 +-
 drivers/gpu/drm/gma500/psb_intel_lvds.c          |   2 +-
 drivers/gpu/drm/gma500/psb_intel_sdvo.c          |   3 +-
 drivers/gpu/drm/i2c/tda998x_drv.c                |   2 +-
 drivers/gpu/drm/i915/intel_crt.c                 |   2 +-
 drivers/gpu/drm/i915/intel_ddi.c                 |   2 +-
 drivers/gpu/drm/i915/intel_display.c             | 250 +++++++++++++----------
 drivers/gpu/drm/i915/intel_dp.c                  |   2 +-
 drivers/gpu/drm/i915/intel_dp_mst.c              |   2 +-
 drivers/gpu/drm/i915/intel_dsi.c                 |  16 +-
 drivers/gpu/drm/i915/intel_dvo.c                 |  18 +-
 drivers/gpu/drm/i915/intel_fbdev.c               |   5 +-
 drivers/gpu/drm/i915/intel_hdmi.c                |   2 +-
 drivers/gpu/drm/i915/intel_lvds.c                |   2 +-
 drivers/gpu/drm/i915/intel_sdvo.c                |   3 +-
 drivers/gpu/drm/i915/intel_sprite.c              |  50 +++--
 drivers/gpu/drm/i915/intel_tv.c                  |   2 +-
 drivers/gpu/drm/imx/dw_hdmi-imx.c                |   2 +-
 drivers/gpu/drm/imx/imx-drm-core.c               |   2 +-
 drivers/gpu/drm/imx/imx-ldb.c                    |   2 +-
 drivers/gpu/drm/imx/imx-tve.c                    |   2 +-
 drivers/gpu/drm/imx/ipuv3-plane.c                |   3 +-
 drivers/gpu/drm/imx/parallel-display.c           |   2 +-
 drivers/gpu/drm/mgag200/mgag200_mode.c           |   2 +-
 drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c         |   3 +-
 drivers/gpu/drm/msm/mdp/mdp4/mdp4_dtv_encoder.c  |   2 +-
 drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c |   2 +-
 drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c        |   3 +-
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_cmd_encoder.c  |   2 +-
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c         |   3 +-
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_encoder.c      |   2 +-
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c        |   2 +-
 drivers/gpu/drm/nouveau/dispnv04/dac.c           |   3 +-
 drivers/gpu/drm/nouveau/dispnv04/dfp.c           |   2 +-
 drivers/gpu/drm/nouveau/dispnv04/tvnv04.c        |   3 +-
 drivers/gpu/drm/nouveau/dispnv04/tvnv17.c        |   3 +-
 drivers/gpu/drm/nouveau/nv50_display.c           |   6 +-
 drivers/gpu/drm/omapdrm/omap_crtc.c              |   2 +-
 drivers/gpu/drm/omapdrm/omap_encoder.c           |   2 +-
 drivers/gpu/drm/omapdrm/omap_plane.c             |   2 +-
 drivers/gpu/drm/qxl/qxl_display.c                |   2 +-
 drivers/gpu/drm/radeon/atombios_encoders.c       |  30 ++-
 drivers/gpu/drm/radeon/radeon_dp_mst.c           |   2 +-
 drivers/gpu/drm/radeon/radeon_legacy_encoders.c  |  15 +-
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c           |   2 +-
 drivers/gpu/drm/rcar-du/rcar_du_encoder.c        |   2 +-
 drivers/gpu/drm/rcar-du/rcar_du_hdmienc.c        |   2 +-
 drivers/gpu/drm/rcar-du/rcar_du_plane.c          |   3 +-
 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c      |   2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c      |   6 +-
 drivers/gpu/drm/shmobile/shmob_drm_crtc.c        |   2 +-
 drivers/gpu/drm/sti/sti_crtc.c                   |   2 +-
 drivers/gpu/drm/sti/sti_cursor.c                 |   2 +-
 drivers/gpu/drm/sti/sti_gdp.c                    |   2 +-
 drivers/gpu/drm/sti/sti_hqvdp.c                  |   2 +-
 drivers/gpu/drm/sti/sti_tvout.c                  |   7 +-
 drivers/gpu/drm/tegra/dc.c                       |  11 +-
 drivers/gpu/drm/tegra/dsi.c                      |   2 +-
 drivers/gpu/drm/tegra/hdmi.c                     |   2 +-
 drivers/gpu/drm/tegra/rgb.c                      |   2 +-
 drivers/gpu/drm/tegra/sor.c                      |   2 +-
 drivers/gpu/drm/tilcdc/tilcdc_panel.c            |   2 +-
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c           |   2 +-
 drivers/gpu/drm/udl/udl_encoder.c                |   3 +-
 drivers/gpu/drm/vc4/vc4_crtc.c                   |   2 +-
 drivers/gpu/drm/vc4/vc4_hdmi.c                   |   2 +-
 drivers/gpu/drm/vc4/vc4_plane.c                  |   2 +-
 drivers/gpu/drm/virtio/virtgpu_display.c         |   4 +-
 drivers/gpu/drm/virtio/virtgpu_plane.c           |   2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c              |   2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c             |   2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c             |   2 +-
 include/drm/drm_crtc.h                           |  12 +-
 105 files changed, 543 insertions(+), 344 deletions(-)

-- 
2.4.10



More information about the Intel-gfx mailing list